add kwarg constructor as documented #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome @disberd ! Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
TextHighlighterconstructor that takeskwargsand construct aCrayonobject implicitly from those.This is still a documented constructor but is not present anymore in the v3 API.
I thought it was more meaningful to add it back (rather than to do PR to it from the docstring) and also thought it wasn't very julian to make it an inner constructor (though I see you are putting all constructors as inner @ronisbr), so can easily make it inner if preferred (or even just make this a change of docstring PR if your new API does not envisage this constructor)