Fix warnings in Dart Sass #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The more complicated, better fix would be to rebase our patches on top of the latest version of minimal-mistakes, but they don't apply cleanly.
Member
|
I'd rather want to update our minimal mistakes. I will have a look. |
Author
|
No problem. Note that the warnings only appear with Ruby 3, and to use Ruby 3 we would need to switch to Jekyll 4, and that's its own can of worms (but doable, see root-project/web#862). The rationale for all of this yak shaving is that Ruby 2.7 is end of life. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These warnings appear with a more recent version of Ruby, e.g. Ruby 3 (see also root-project/web#862).
The more complicated, better fix would be to rebase our patches on top of the latest version of minimal-mistakes, but they don't apply cleanly (we are 300+ commits behind upstream).
WARNING: I have not checked whether these changes work with the old version of Ruby that we currently use to build the website!