Add tests for std::pair and std::tuple
#46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Perhaps it makes sense to add fields with nesting? |
Member
Author
|
Discussion from the IO meeting: we want a record type as element, so for example nested |
Member
Author
|
ping @pcanal @silverweed can you take a look? I believe I'm implementing everything we discussed last Friday. |
pcanal
reviewed
May 7, 2025
pcanal
reviewed
May 7, 2025
silverweed
approved these changes
May 9, 2025
Contributor
silverweed
left a comment
silverweed
left a comment
There was a problem hiding this comment.
Sorry for taking long to review, it looks good to me.
jblomer
approved these changes
May 14, 2025
pcanal
approved these changes
May 14, 2025
hahnjo
force-pushed
the
pair-tuple
branch
2 times, most recently
from
f868583 to
d9e3972
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::pair(closes Test forstd::pair#17)std::tuple(closes Test forstd::tuple#18)