[core] improve TDirectory::DecodeNameCycle #18244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 19 files 19 suites 4d 21h 32m 6s ⏱️ For more details on these failures, see this check. Results for commit 24deac7. ♻️ This comment has been updated with latest results. |
pcanal
reviewed
Apr 3, 2025
pcanal
reviewed
Apr 3, 2025
pcanal
reviewed
Apr 3, 2025
- avoid scanning the string twice - allow `name` to be null if one only wants the cycle - return the actual name length so the caller can know whether the name was truncated or not - improve function documentation
silverweed
force-pushed
the
tdir_decodenamecycle
branch
from
c307939 to
24deac7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nameto be null if one only wants the cycleChecklist: