Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v632] Fix macOS15.4 builds #18245

Merged
merged 5 commits into from
Apr 5, 2025

Conversation

devajithvs
Copy link
Contributor

@devajithvs devajithvs commented Apr 3, 2025

@devajithvs devajithvs self-assigned this Apr 3, 2025
@devajithvs devajithvs added the clean build Ask CI to do non-incremental build on PR label Apr 3, 2025
@devajithvs devajithvs closed this Apr 3, 2025
@devajithvs devajithvs reopened this Apr 3, 2025
Copy link

github-actions bot commented Apr 3, 2025

Test Results

     9 files       9 suites   2d 3h 51m 36s ⏱️
 3 838 tests  3 820 ✅ 18 💤 0 ❌
22 379 runs  22 379 ✅  0 💤 0 ❌

Results for commit 004d354.

♻️ This comment has been updated with latest results.

@devajithvs devajithvs requested a review from couet as a code owner April 3, 2025 13:48
@devajithvs devajithvs changed the title [v632] [runtime-cxxmodules] Adapt the darwin modulemaps to sdk 15.4. (#18231) [v632] Fix macOS15.4 builds Apr 3, 2025
ktf and others added 5 commits April 4, 2025 11:34
`less` is defined in functional according to the C++ standard.

(cherry picked from commit 82858ce)
…roject#18231)

* [runtime-cxxmodules] Adapt the darwin modulemaps to sdk 15.4.

* [runtime-cxmodules] Use separate modulemap for macOS15.2

* [runtime-cxxmodules] Add overlay entry for MacOSX15.2

---------

Co-authored-by: Devajith Valaparambil Sreeramaswamy <[email protected]>
(cherry picked from commit ff43ae8)
Clang may emit calls to compiler-rt symbols such as __divdc3 for
std::complex<T> division. These may not be resolved during JIT'ing
on macOS when using Cling.

This patch forward-declares the relevant symbols and explicitly
injects them into the JIT symbol table.

Similar to: root-project@4b6075b

(cherry picked from commit 038ee1f)
Thanks to @ktf (ALICE) for this fix.

(cherry picked from commit 21a9e6c)
to address the new behaviour of the compiler shipped with XCode 16.3
@devajithvs devajithvs requested a review from pcanal as a code owner April 4, 2025 09:37
@dpiparo dpiparo closed this Apr 4, 2025
@dpiparo dpiparo reopened this Apr 4, 2025
@dpiparo dpiparo merged commit f22fde6 into root-project:v6-32-00-patches Apr 5, 2025
19 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean build Ask CI to do non-incremental build on PR pr:backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants