[json] Check dictionary for std::map object in streaming #18266
Conversation
When stream directly std::map object in macro like: ``` std::map<int,string> m; m[1] = "number 1"; m[2] = "number 2"; auto json = TBufferJSON::ToJSON(&m); ``` Real dictionary class for std::map is required. It checked automatically when map is member of user class, but was not checked when map object intself streamed
Same when write object, reading is not possible for std::map<> object without dictionary
|
Is this fixing #18195 ? |
|
It prevents crash of ROOT in situation reported in #18195 - which is just our documentation. But it is still open question if code was working before without dictionary. |
|
It is my understanding that this never worked, right @rlalik? |
|
Code taken from here: https://github.com/root-project/root/blob/master/io/io/src/TBufferJSON.cxx#L50-L64 I put it in comments in ROOT version 6.18. One probably can try to start ROOT 6.18 and test it |
It was the very first time I used this feature so cannot say about the past. |
|
I check |
While std::map uses in TBufferJSON in documentaiton, mention gInterpreter->GenerateDictionary
Test Results 17 files 17 suites 4d 9h 49m 1s ⏱️ For more details on these failures, see this check. Results for commit 50c6fd4. |
When stream directly
std::mapobject in macro like:Real dictionary class for
std::mapis required.It checked automatically when map is member of user class,
but was not checked when map object itself streamed