Avoid including ambiguous TTree branch names #19399
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
a few builds failed because of |
This reverts commit 235a67a.
Test Results 22 files 22 suites 3d 18h 42m 47s ⏱️ For more details on these failures, see this check. Results for commit 028676a. ♻️ This comment has been updated with latest results. |
When the input data source is a TTree, GetColumnNames gathers the list of all
the available TTree branches. In case there are two branches in the tree (e.g.
`el1` and `el2`), each of them has a sub-branch with the same name (e.g.
`electron_pt`), TTree allows calling `GetBranch("electron_pt")` and returns the
pointer to the sub-branch of the first main branch (i.e. `el1.electron_pt`).
This behaviour can lead to ambiguities, thus avoid exposing the ambiguous column
name via RDF.
A test is added to exemplify this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the input data source is a TTree, GetColumnNames gathers the list of all the available TTree branches. In case there are two branches in the tree (e.g.
el1andel2), each of them has a sub-branch with the same name (e.g.electron_pt), TTree allows callingGetBranch("electron_pt")and returns the pointer to the sub-branch of the first main branch (i.e.el1.electron_pt). This behaviour can lead to ambiguities, thus avoid exposing the ambiguous column name via RDF.A test is added to exemplify this case.
This PR fixes #19392
Note that it is a draft PR as the fix is fairly obvious but I am not sure that it won't break other tests