[Geom] TGeoVGConverter: Introduce shape-type filtering for conversion process #20489
+96
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hello @agheata , Here is the PR that we discussed during Geant4 Collaboration Meeting. |
- Added functions 'SelectShapeType()' and 'ExcludeShapeType()'. Conversion is performed only on selected shapes (if set), and excluded shapes are always skipped. - TGeoVGShape: Disabled conversion for problematic edge cases not covered by exclusion: 'TGeoBBox' with shifted origin and 'TGeoScaledShape'.
ihrivnac
force-pushed
the
vg-converter-shape-filtering
branch
from
aae3a6f to
d94fe26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functions
SelectShapeType()andExcludeShapeType(). Conversion is performed only on selected shapes (if set), and excluded shapes are always skipped.TGeoVGShape: Disabled conversion for problematic edge cases not covered by exclusion: 'TGeoBBox' with shifted origin and 'TGeoScaledShape'.
This Pull request:
Changes or fixes:
SelectShapeType()andExcludeShapeType()functions toTVirtualGeoConverterandTGeoVGConverterTGeoVGShape::Convert(): Disabled conversion for 'TGeoBBox' with shifted origin and 'TGeoScaledShape'Checklist:
This PR fixes #