[ci] Simplify build configuration and pick up specific options #20857
+119
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpiparo
force-pushed
the
fix_benchmark
branch
5 times, most recently
from
be28e6d to
56a5da2
Compare
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 9397ad8. ♻️ This comment has been updated with latest results. |
dpiparo
changed the title
dpiparo
force-pushed
the
fix_benchmark
branch
13 times, most recently
from
81bbfd2 to
7b32260
Compare
Builds requiring special configurations can now be defined in the workflow definition file through the parameter "platform_config". The parsing of such options has been enhanced. In a nutshell: 1. If "platform_config" is not specified, the platform name is considered instead and the configuration file <platform>.txt is read. This is for compatibility with the previous behaviour. 2. If "platform_config" is specified, the file <platform_config>.txt file is read. 3. If the "minimal" option is specified in a platform configuration file, the global configuration (global.txt) is ignored. 4. If the option CMAKE_GENERATOR is specified in a platform configuration file, it will be properly passed through the "-G" CMake switch. Previously the value had to be specified as a workflow parameter and passed as an environment variable.
dpiparo
force-pushed
the
fix_benchmark
branch
from
7b32260 to
84f0a7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decouples the concept of plarform and platform configuration. If no platform configuration is specified, the default platform configuration is picked. Otherwise, a special one,
<platform>-<config label>.txtis picked.This has multiple benefits, at least: