[tmva][sofie][ci] Enable TMVA SOFIE on all Linux platforms and add Python 3.14 support for SOFIE tests#21483
Open
guitargeek wants to merge 2 commits intoroot-project:masterfrom
Open
[tmva][sofie][ci] Enable TMVA SOFIE on all Linux platforms and add Python 3.14 support for SOFIE tests#21483guitargeek wants to merge 2 commits intoroot-project:masterfrom
guitargeek wants to merge 2 commits intoroot-project:masterfrom
Conversation
guitargeek
changed the title
guitargeek
changed the title
PyTorch’s new torch.export/Dynamo-based ONNX exporter fails under Python 3.14 (onnxscript typeinfo/typing.Union error), causing the SOFIE model generator scripts to crash before writing the .onnx files and making the tests fail. This commit suggests to make use of the dynamo exporter on the interpreter version: * import sys and compute `dynamo_export` flag from `sys.version_info` * pass `dynamo=dynamo_export` to `torch.onnx.export(...)` * keep existing special-cases (e.g. batchnorm still forces legacy export) This restores SOFIE ONNX generation and fixes Conv1d/Conv3d (and related) test failures on Python 3.14 while preserving the current behavior on other Python versions.
We were inconsistent about where we enabled `tmva-sofie`, and the newer Linux platforms didn't have it. It would be good to enable it also for new Fedoras and Ubuntus to get test coverage of new developments.
Test Results 22 files 22 suites 3d 7h 24m 48s ⏱️ For more details on these failures, see this check. Results for commit 24c3c4c. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were inconsistent about where we enabled
tmva-sofie, and the newer Linux platforms didn't have it. It would be good to enable it also for new Fedoras and Ubuntus to get test coverage of new developments.