[rfile] Add some more information in RKeyInfo#21486
Open
silverweed wants to merge 1 commit intoroot-project:masterfrom
Open
[rfile] Add some more information in RKeyInfo#21486silverweed wants to merge 1 commit intoroot-project:masterfrom
silverweed wants to merge 1 commit intoroot-project:masterfrom
Conversation
jblomer
approved these changes
Mar 4, 2026
pcanal
reviewed
Mar 4, 2026
Test Results 21 files 21 suites 3d 1h 34m 23s ⏱️ For more details on these failures, see this check. Results for commit 729b95f. |
silverweed
commented
Mar 5, 2026
| /// Returns the on-disk size of the (potentially compressed) object, excluding its key. | ||
| std::uint64_t GetObjNBytes() const { return fObjNBytes; } | ||
| /// Returns the on-disk size of this object's key. | ||
| std::uint64_t GetKeyLen() const { return fKeyLen; } |
Contributor
Author
There was a problem hiding this comment.
Should we call this GetKeyNBytes for consistency (since it's the on-disk size)?
On the other hand TKeys are, as far as I understand, always stored uncompressed, so this is equal to the uncompressed length.
hahnjo
reviewed
Mar 6, 2026
Comment on lines
+551
to
+552
| fKeySeek(key.GetSeekKey()), | ||
| fParentDirSeek(key.GetSeekPdir()) |
Member
There was a problem hiding this comment.
Do we maybe want to call this "offset"? I'm always confused because a "seek" is not a thing (I know)
Member
There was a problem hiding this comment.
The meta question is whether we want to stick close to the underlying names or invent new/better names for the 'same' things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.