Skip to content

[rfile] set default compression to 505 and add SetCompressionSettings#21494

Open
silverweed wants to merge 1 commit intoroot-project:masterfrom
silverweed:rfile_compression
Open

[rfile] set default compression to 505 and add SetCompressionSettings#21494
silverweed wants to merge 1 commit intoroot-project:masterfrom
silverweed:rfile_compression

Conversation

@silverweed
Copy link
Contributor

Note that GetCompressionSettings() is not provided at this time because it has ambiguous semantics and we need to decide if we want to provide it at all.

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@silverweed silverweed self-assigned this Mar 4, 2026
@silverweed silverweed requested a review from pcanal as a code owner March 4, 2026 15:48
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

Test Results

    22 files      22 suites   3d 5h 15m 3s ⏱️
 3 828 tests  3 827 ✅ 1 💤 0 ❌
76 601 runs  76 592 ✅ 9 💤 0 ❌

Results for commit ec4b9e9.

♻️ This comment has been updated with latest results.

@silverweed silverweed added the clean build Ask CI to do non-incremental build on PR label Mar 5, 2026
@silverweed
Copy link
Contributor Author

silverweed commented Mar 5, 2026

NOTE: changed the exception to a warning in case the file is not writable, as the operation is just a no-op and not fatal.

Edit: I changed it again to remove SetCompressionSettings, at least for now, and only allow setting the compression during Recreate. We can decide to add back SetCompressionSettings later if needed.

@silverweed silverweed requested a review from jblomer March 6, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean build Ask CI to do non-incremental build on PR in:I/O

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants