Skip to content

Minor Readme Enhancements #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

Thunder-Blaze
Copy link
Contributor

Proposed Changes

  • Updated Discord Img Shield
  • Added Img Shields for Made with Love, Stars, License, Issues
  • Centered the Extension Store Links

Preview

image

Checklist

  • I have tested my changes thoroughly.
  • I have updated the documentation accordingly.
  • My code follows the project's coding conventions and style.
  • I have added necessary comments to my code, particularly in complex areas.
  • I have ensured that my changes do not introduce any new issues.

@rootCircle
Copy link
Owner

Looks awesome!

Mind if you can add PR:Welcome and Build (gh_workflow) label as well?

@Thunder-Blaze
Copy link
Contributor Author

idk if I got this right but do you mean this ?
 
or this one ?

@rootCircle
Copy link
Owner

I think second but the content should be just "welcome"

And another workflow for github actions status(aka build workflow)

@Thunder-Blaze
Copy link
Contributor Author

Thunder-Blaze commented Dec 19, 2024

and

these ? If yes, which one out of the below two to keep or should I keep both

better version ->

@rootCircle
Copy link
Owner

I guess first PR "Welcome and Build" badge was more consistent with the theme, so prefer that instead of this!

Also, for builds check if you can use consistent layouts. If not, move forward with these only!

@Thunder-Blaze
Copy link
Contributor Author

check the updated comment, and btw if it is color problem, I can change them as you want

@rootCircle
Copy link
Owner

Yes change the color as well! Rest all is awesome!

@Thunder-Blaze
Copy link
Contributor Author

 

I've used lint-check.yml (health check) for the 2nd badge
Should I create one for secrets-scanning.yml (gitleaks) too ?

@rootCircle
Copy link
Owner

No it's not required!

@Thunder-Blaze
Copy link
Contributor Author

image

should I finalize this ?

@rootCircle
Copy link
Owner

Looks awesome! Go ahead!🎉🎉

@Thunder-Blaze
Copy link
Contributor Author

Done, you can view the changes here before merging Readme.md

@rootCircle rootCircle self-requested a review December 19, 2024 19:37
@rootCircle rootCircle merged commit 42a8522 into rootCircle:dev Dec 19, 2024
2 checks passed
@rootCircle
Copy link
Owner

LGTM! Thanks for your contribution!

@Thunder-Blaze Thunder-Blaze deleted the ReadmeEnhancement branch December 20, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants