Skip to content

fix: Popup Responsiveness and Link Interactivity #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 25, 2024
Merged

fix: Popup Responsiveness and Link Interactivity #76

merged 2 commits into from
Dec 25, 2024

Conversation

Thunder-Blaze
Copy link
Contributor

Proposed Changes

  • Changed Width of Popup to 320px, now it will work on the smallest mobile screens without issue
  • Removed the pointer events of toast container, so that it won't be clicked and the links below will be clicked

Related Issue

Fixes #74
Fixes #75

Checklist

  • I have tested my changes thoroughly.
  • I have updated the documentation accordingly.
  • My code follows the project's coding conventions and style.
  • I have added necessary comments to my code, particularly in complex areas.
  • I have ensured that my changes do not introduce any new issues.

@rootCircle rootCircle self-requested a review December 25, 2024 09:28
@rootCircle
Copy link
Owner

LGTM 👍 Thanks for your contributions

@rootCircle rootCircle merged commit 136d4b5 into rootCircle:dev Dec 25, 2024
2 checks passed
@Thunder-Blaze Thunder-Blaze deleted the Fix/ResponsivenessAndInteractivity branch December 25, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootCircle rootCircle rootCircle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Privacy policy is not clickable in popup Fix popup responsiveness for mobile devices
2 participants
@Thunder-Blaze @rootCircle