🔧 Disable script concatenation by default #717
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swalkinshaw
approved these changes
Apr 25, 2024
|
Should we take it one step further to disable The CDN and web servers (e.g: nginx, apache, etc) should take care of those. |
|
I started getting problems with this after updating nginx from 1.21.7 to 1.27.2. Not with timeout to load-styles.php like many people report but nginx would just return connection reset by peer. Setting CONCATENATE_SCRIPTS to false solved the problem. Not sure why it happens but seems WordPress does something not compatible with latest nginx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets
CONCATENATE_SCRIPTSto false by default which prevents WordPress from concatenating scriptsRef https://discourse.roots.io/t/upstream-timed-out-for-load-styles-php/26973