Some refactoring around tests #275
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t delete what's self-cleaning
|
@mpadge I didn't even get to the OS-specific stuff. 🤪 |
maelle
commented
Jul 11, 2025
|
|
||
| h <- readLines (f) | ||
| # href | ||
| h[grep("Click to see", h)] <- "<p>Clickety clop</p>" |
There was a problem hiding this comment.
this and the package version thingie above is annoying, as I suspect it should be handled by the existing code?
For the href I think you were trying to very deterministically replace the temporary directory, this is more hacky.
maelle
commented
Jul 11, 2025
| @@ -188,6 +188,102 @@ <h3>2. Package Dependencies</h3> | |||
| </tbody> | |||
| </table> | |||
| <p>Click below for tallies of functions used in each package. Locations of each call within this package may be generated locally by running ‘s <- pkgstats::pkgstats(<path to repo>)’, and examining the ‘external_calls’ table.</p> | |||
| <details> | |||
| <summary>base</summary> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready!