Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding new functionality suggested in #107 #108

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

T-Engel
Copy link

@T-Engel T-Engel commented Jun 5, 2019

locate_columns() allows users to manually locate separators between columns. It adopts the approach of the "reduced" widget from the related function locate_areas(). The output can be used as the columns argument in extract_tables().
#107

Please ensure the following before submitting a PR:

  • if suggesting code changes or improvements, open an issue first
  • for all but trivial changes (e.g., typo fixes), add your name to DESCRIPTION
  • for all but trivial changes (e.g., typo fixes), documentation your change in NEWS.md with a parenthetical reference to the issue number being addressed
  • if changing documentation, edit files in /R not /man and run devtools::document() to update documentation
  • add code or new test files to /tests for any new functionality or bug fix.
  • make sure R CMD check runs without error before submitting the PR

I am not familiar with test files. Could anyone help me here? How do I test an interactive function?

locate_columns allows users to manually locate separators between columns. It adopts the approach of the "reduced" wiget from the related function locate_areas().
locate_columns allows users to manually locate separators between columns. It adopts the approach of the "reduced" wiget from the related function locate_areas().
@T-Engel
Copy link
Author

T-Engel commented Jun 5, 2019

I don't understand why build job 110.5 failed on travis. Any ideas?

@codecov-io
Copy link

codecov-io commented Jan 10, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@7723d2b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #108   +/-   ##
=========================================
  Coverage          ?   52.25%           
=========================================
  Files             ?       13           
  Lines             ?      666           
  Branches          ?        0           
=========================================
  Hits              ?      348           
  Misses            ?      318           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7723d2b...d08f1c5. Read the comment docs.

@pachadotdev
Copy link
Contributor

let me test how these changes go with tabula 1.0.5

@pachadotdev
Copy link
Contributor

hi @T-Engel
I will build again after fixing all the conflicts and try with gh-actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants