-
Notifications
You must be signed in to change notification settings - Fork 14
Only record headers if needed #450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Proof of concept. Fixes #417.
I think I resolved the conflict correctly, change if not. |
Yeah, that looks reasonable to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're dropping the headers slot from the interaction written to disk, but we're leaving an empty request body slot there still as body: {}
. Maybe we should be consistent about that? Or leave body as is?
We should document this request header behavior for users. Probably in the param def for match_requests_on
in use_cassette()
, and maybe in the getting started vignette
me too |
Yeah, let me apply the same treatment to body, and add some extra docs. |
Do you think we should also drop the body if ... I went ahead and did it since it seems the most consistnent. |
I also need to update the secrets vignette. |
Proof of concept. Fixes #417.
@sckott started on this so you'd have something to give concrete feedback on. I do like that it eliminates the chances of leaking keys for the majority of APIs.