Debugging overhaul #456
Debugging overhaul #456
Conversation
With a focus on logging, which has lead to quite a few minor tweaks to the existing logging output.
|
@sckott I think it would be interesting for you to look at the rendered vignette and contemplate if there's a way for me to convince you that logging + a vignette can be better than the custom error messages. |
|
@hadley I'll do that. we're packing for a weekend trip then heading off soon, so I won't look at anything until monday :) |
|
I like this, thanks. I guess the WRT replacing logging with errors.R i'll try that locally and see how it feels |
|
I put together #488 just to get concrete |
|
Thanks @maelle — I was on a plane with crappy wifi. |
vignettes/debugging.Rmd
Outdated
| @@ -1,149 +1,205 @@ | |||
| --- | |||
| title: "Debugging your tests that use vcr" | |||
There was a problem hiding this comment.
the title has to be updated here (the two changes that are in vcr.Rmd at the moment)
vignettes/debugging.Rmd
Outdated
| This vignette helps you debug the vcr error that you're most likely to encounter: "Failed to find matching request in active cassette.". | ||
| If you're lucky, the request has genuinely changed, and you can make this problem go away by deleting the previous cassette so vcr can re-record it 🙂. | ||
| Otherwise, you'll need to do some debugging. | ||
| First we'll talk about logging, and how you can use it to better understand vcr's request matching process. |
There was a problem hiding this comment.
| First we'll talk about logging, and how you can use it to better understand vcr's request matching process. | |
| First we'll talk about logging, and how you can use it to better understand vcr's request matching process (comparing your real request against any requests stored in cassettes). |
maybe put something in parentheses like above?
Co-authored-by: Scott Chamberlain <[email protected]> Co-authored-by: Maëlle Salmon <[email protected]>
|
I think I got all the changes, please let me know if I missed anything! |
|
Thank you! To me the only thing missing is a brief explanation of what |
|
All LGTM other than @maelle question about local |
With a focus on logging, which has lead to quite a few minor tweaks to the existing logging output.