-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move speed limiter from ros2_control repo #212
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ros2-master #212 +/- ##
===============================================
- Coverage 51.20% 49.91% -1.30%
===============================================
Files 10 12 +2
Lines 496 595 +99
Branches 59 78 +19
===============================================
+ Hits 254 297 +43
- Misses 215 255 +40
- Partials 27 43 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Very simple. We should relicense all bsd to apache. |
2c35a8c
to
11a9d31
Compare
Co-authored-by: Dr. Denis <[email protected]>
T min_value = NAN, T max_value = NAN, | ||
T min_first_derivative_neg = NAN, T max_first_derivative_pos = NAN, | ||
T min_first_derivative_pos = NAN, T max_first_derivative_neg = NAN, | ||
T min_second_derivative = NAN, T max_second_derivative = NAN); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use the C++ NaN
version and not C version.
Basically, the NaN
should be changed to std::numeric_limits<double>::quiet_NaN()
- and probably add #include <limits>
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
I thought it would be beneficial to reuse the SpeedLimiter of the diff_drive controller in the steering_controllers_library.
The SpeedLimiter might be useful for other controllers as well, so I suggest to add it to the control_toolbox repo.
I renamed it to rate_limiter, because it just limits the value and some derivatives, and could be used as control_filter plugin for other variables than speed.
Additionally, I added some tests because there were none.