First step towards modernizing the rt publisher (backport #210)#233
Merged
christophfroehlich merged 2 commits intohumblefrom Dec 19, 2024
Merged
First step towards modernizing the rt publisher (backport #210)#233christophfroehlich merged 2 commits intohumblefrom
christophfroehlich merged 2 commits intohumblefrom
Conversation
(cherry picked from commit e58c7ad)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## humble #233 +/- ##
==========================================
+ Coverage 76.15% 76.54% +0.39%
==========================================
Files 8 8
Lines 478 486 +8
Branches 183 184 +1
==========================================
+ Hits 364 372 +8
Misses 77 77
Partials 37 37
Flags with carried forward coverage won't be shown. Click here to find out more.
|
christophfroehlich
approved these changes
Dec 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the rt publisher is one of the most commonly used tools in this package.
When ever I was using it I stumbled upon its "weird" API.
This PR is a first step towards modernizing the RealtimePublisher class, providing a tiny bit of comfort by adding a
tryPublishmethod and providing some typedefs similar to the rclcpp::Publisher.I plan to add a follow up PR where I refactor the NON_POLLING define into a template parameter.
This is an automatic backport of pull request #210 done by Mergify.