joy_linux: clean shutdown when terminated by signal handler #293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The joy_linux node does not shut down gracefully if terminated by a signal, for example CTRL+C/SIGINT. This happens because the context is invalidated by the signal handler, and the node main function attempts to call spin_node directly after exiting the innermost while loop. Example of unclean exit:
This PR moves the offending call to spin_some inside the rclcpp::ok() check to at least catch most of these cases. This results in a clean shutdown without the exception: