Accept rmw_qos_profile_t for topic camera QoS initialization #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea: To add custom QoS Profiles to camera publisher topics.
Problem: CameraPublisher from imagetransport(humble branch) doesn't support rclcpp::PublisherOptions. So qos_overrides might not work. https://github.com/ros-perception/image_common/blob/5e4dd9ed2daae23a6d06ff98e0a5bef19a9314da/image_transport/src/image_transport.cpp#L78
Instead added a rmw_qos_profile_t struct based initialization to each topic in usb_cam_node.cpp
Related to Issue #375