Load module feature #128
Load module feature #128
Conversation
|
@jontje any chance this could be merged in the near future? |
I don't have time this week, but I should be able to find some time for testing and reviewing either next week or the week after that. |
|
That would be great, thanks! |
|
Any updates on this? |
|
I'm really sorry about leaving this open for so long @dorianleveque and @Wojcik98. It's not because it's uninteresting or unwanted, far from it. I am going to leave the review to @jontje though. |
|
I have unfortunately not been able to find any time for the review due to higher priority tasks, and I am currently unsure when things will ease up. |
| RWSClient::RWSResult RWSClient::loadModuleIntoTask(const std::string& task, const FileResource& resource, const bool replace) | ||
| { | ||
| std::string uri = generateRAPIDTasksPath(task) + "?" + Queries::ACTION_LOAD_MODULE; | ||
| std::string content = Identifiers::MODULEPATH + "=" + generateFilePath(resource) + "&replace=" + ((replace) ? "true" : "false"); |
There was a problem hiding this comment.
Path to the file should be a direct path, i.e. "{directory}/{filename}", but generateFilePath(resource) adds "fileservice/" at the beginning.
4 participants
No description provided.