Skip to content

Conversation

@EricMarcil
Copy link
Contributor

Add the support package for the Yaskawa GP165R robot

EricMarcil and others added 2 commits January 28, 2025 16:32
Add the support package for the Yaskawa GP165R robot
@gavanderhoorn
Copy link
Member

Other comment: this model appears to have a balancer unit. As we're not modelling the actual motion of that, I would suggest removing the piston.

When the arm rotates back, the piston starts intersecting with the arm. This can make motion planners consider that a collision -- unless it has been disabled on purpose.

Just removing the piston would avoid that completely I believe.

@EricMarcil
Copy link
Contributor Author

Other comment: this model appears to have a balancer unit. As we're not modelling the actual motion of that, I would suggest removing the piston.

When the arm rotates back, the piston starts intersecting with the arm. This can make motion planners consider that a collision -- unless it has been disabled on purpose.

Just removing the piston would avoid that completely I believe.

@gavanderhoorn I looked at removing just the piston, it doesn't change much, because we then use a convex hull on the model to create the collision model which will collide with the L-axis anyway.

image

The orange outline is the model without the piston, so not much of a difference.

Added information about the GP165R - Equipped version
@gavanderhoorn
Copy link
Member

Thanks for checking.

I agree about the convex hull, but not all planning tools use it.

Having the 'detailed' mesh also not intersecting with the arm covers all cases and doesn't really reduce visual fidelity.

The balancer piston which is not animated was removed to avoid false collision with the link_2_l model during motion.
@EricMarcil
Copy link
Contributor Author

@gavanderhoorn I've updated the link_1_s and removed the piston as per your request.

Variant name before file name.
Needs some file duplication, but it's at least consistent with other packages.
Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for green CI, but approving already.

@gavanderhoorn gavanderhoorn merged commit ee12cd6 into ros-industrial:kinetic-devel Feb 7, 2025
2 checks passed
@gavanderhoorn
Copy link
Member

Thanks @EricMarcil 👍

@EricMarcil
Copy link
Contributor Author

@gavanderhoorn Thanks for all the recent reviews and merge!

@EricMarcil EricMarcil deleted the GP165R branch March 19, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants