-
Notifications
You must be signed in to change notification settings - Fork 206
GP165R robot support package #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add the support package for the Yaskawa GP165R robot
|
Other comment: this model appears to have a balancer unit. As we're not modelling the actual motion of that, I would suggest removing the piston. When the arm rotates back, the piston starts intersecting with the arm. This can make motion planners consider that a collision -- unless it has been disabled on purpose. Just removing the piston would avoid that completely I believe. |
@gavanderhoorn I looked at removing just the piston, it doesn't change much, because we then use a convex hull on the model to create the collision model which will collide with the L-axis anyway. The orange outline is the model without the piston, so not much of a difference. |
Added information about the GP165R - Equipped version
|
Thanks for checking. I agree about the convex hull, but not all planning tools use it. Having the 'detailed' mesh also not intersecting with the arm covers all cases and doesn't really reduce visual fidelity. |
The balancer piston which is not animated was removed to avoid false collision with the link_2_l model during motion.
|
@gavanderhoorn I've updated the link_1_s and removed the piston as per your request. |
Variant name before file name.
Needs some file duplication, but it's at least consistent with other packages.
gavanderhoorn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for green CI, but approving already.
|
Thanks @EricMarcil 👍 |
|
@gavanderhoorn Thanks for all the recent reviews and merge! |

Add the support package for the Yaskawa GP165R robot