Const and other #374
Open
Const and other #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 8, 2025 07:38
Signed-off-by: Gaël Écorchard <[email protected]>
Signed-off-by: Gaël Écorchard <[email protected]>
Signed-off-by: Gaël Écorchard <[email protected]>
Signed-off-by: Gaël Écorchard <[email protected]>
destogl
approved these changes
Sep 2, 2025
Timple
reviewed
Nov 10, 2025
| uint8_t node_id = config_->get_entry<uint8_t>(*it, "node_id").value(); | ||
| std::string change_state_client_name = *it; | ||
| std::string get_state_client_name = *it; | ||
| uint8_t node_id = config_->get_entry<uint8_t>(device, "node_id").value(); |
There was a problem hiding this comment.
CI:
/root/target_ws/src/ros2_canopen/canopen_core/src/lifecycle_manager.cpp:80:51: error: ‘device’ was not declared in this scope
Not sure how this happens as the code looks correct...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detail things I did while studying the code. Just didn't want to lose them.