-
Notifications
You must be signed in to change notification settings - Fork 3
feat(order_execution): adds OrderManager #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
…ared_ptr to node Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Fix on Issue #4: Required APIs from StateMananger.
…to it and changing update_current_order Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
… update Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
|
Thanks for all the great work on this! Some high-level feedback:
|
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
* fix: export fmt as a dependency for downstream packages Signed-off-by: Saurabh Kamat <[email protected]> * feat: add vda5050 structs for internal use Signed-off-by: Saurabh Kamat <[email protected]> * feat: overload equality/inequality operators Signed-off-by: Saurabh Kamat <[email protected]> * feat: add action.hpp Signed-off-by: Shawn Chan <[email protected]> * feat: add action_parameter.hpp Signed-off-by: Shawn Chan <[email protected]> * feat: add action_parameter_factsheet.hpp Signed-off-by: Shawn Chan <[email protected]> * feat: add action_parameter_value.hpp Signed-off-by: Shawn Chan <[email protected]> * feat: add action_parameter_value_type.hpp Signed-off-by: Shawn Chan <[email protected]> * feat: add action_scope.hpp Signed-off-by: Shawn Chan <[email protected]> * feat: add blocking_type.hpp Signed-off-by: Shawn Chan <[email protected]> * feat: add agv_action.hpp Signed-off-by: Shawn Chan <[email protected]> * feat: add value_data_type.hpp Signed-off-by: Shawn Chan <[email protected]> * feat: add remaining structs for vda5050 messages Signed-off-by: Shawn Chan <[email protected]> * fix: change action param to have key-value pairs instead of custom type Signed-off-by: Saurabh Kamat <[email protected]> * fix: remove optional from action array Signed-off-by: Saurabh Kamat <[email protected]> * fix: remove deleted include Signed-off-by: Saurabh Kamat <[email protected]> * Update vda5050_types/include/vda5050_types/agv_action.hpp * Update vda5050_types/include/vda5050_types/node.hpp * Update vda5050_types/include/vda5050_types/node.hpp --------- Signed-off-by: Saurabh Kamat <[email protected]> Signed-off-by: Shawn Chan <[email protected]> Co-authored-by: Shawn Chan <[email protected]> Co-authored-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
Signed-off-by: Shawn Chan <[email protected]>
…al fields Signed-off-by: Shawn Chan <[email protected]>
Summary
Raising this PR to get feedback on my implementation for the order execution logic. This PR covers Order execution - Order Parsing and Order execution - Node Sequencing.
This PR contains the following features:
NOTE:
IStateManager.hppis a temporary class for mocking the StateManger in the unit tests.