Skip to content

Conversation

@trainman419
Copy link
Contributor

Two patches:

  1. Improve the representations of the ChangesFile object so that it tells us which file it was constructed from
  2. Display which packages were found that were invalid.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between extraneous and invalid packages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extraneous is a set of ChangesFile objects that indicate which changes files are problematic. invalid_changes is new; it's a list of the binary package names from within those changes files that were declared be be invalid.

The result here is that the error output is now something like [ ['python-foo-bar'] ] instead of [ ChangesFile(...) ]

@tfoote tfoote removed their assignment Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants