Use fallback if os_name is found but not os_version #1015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rosdep` fails for the following package even though there is a valid fallback. ```yaml '*': pip: packages: - docstring-parser ubuntu: noble: - python3-docstring-parser ```
clalancette
pushed a commit
to ros/rosdistro
that referenced
this pull request
Oct 8, 2025
* Add pip fallbacks for python3-docstring-parser I previously assumed that the os_name fallback would also apply to missing os_version tags (related issue: ros-infrastructure/rosdep#1015). This fixes this oversight. * Restructured docstring-parser key as requested * Added Ubuntu focal --------- Co-authored-by: Nikolas Dahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed change adds an additional check to see if the
os_versioncan be resolved foros_name- if not the OS fallback is used.Right now
rosdepfails for the following package on e.g. ubuntu jammy even though there is a valid fallback.