Reverse non-zero return codes for rosdep check
#1016
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
This PR builds on #948 because the behavior it implemented resulted in broken dependencies being shadowed by uninstalled packages, ie:
yielding error code
1.This prevented CI from distinguishing between uninstalled packages and broken dependencies.
With this PR, return code values are preserved but users can now check for error code
2and gracefully fail instead of reading error code1and thinking its just a matter of installing packages.Cheers.