feat: python bindings for image_transport and publish (backport #323)#328
Closed
mergify[bot] wants to merge 1 commit intojazzyfrom
Closed
feat: python bindings for image_transport and publish (backport #323)#328mergify[bot] wants to merge 1 commit intojazzyfrom
mergify[bot] wants to merge 1 commit intojazzyfrom
Conversation
Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit c2952b0)
ahcorde
requested changes
Nov 4, 2024
Collaborator
ahcorde
left a comment
ahcorde
left a comment
There was a problem hiding this comment.
Adding new constructors to the class break ABI, I don't think we can backport this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
work in progress
implements #248
This is an automatic backport of pull request #323 done by Mergify.