Fix Windows compilation in image_publisher.cpp #1061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahcorde
approved these changes
Jan 6, 2025
Contributor
|
https://github.com/Mergifyio backport jazzy |
Contributor
✅ Backports have been createdDetails
|
ahcorde
pushed a commit
that referenced
this pull request
Jan 6, 2025
PR #985 added some code that used `M_PI`, but `M_PI` is not defined in any standard, and before including `cmath` or `math.h` in Windows it is necessary to define `_USE_MATH_DEFINES` to ensure that `M_PI` is defined.<hr>This is an automatic backport of pull request #1061 done by [Mergify](https://mergify.com). Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #985 added some code that used
M_PI, butM_PIis not defined in any standard, and before includingcmathormath.hin Windows it is necessary to define_USE_MATH_DEFINESto ensure thatM_PIis defined.