image_view：set CvtColorForDisplay encoding as bgr8 #1071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the issue that the input image encoding as yuv, error to show Signed-off-by: Zhaoyuan Cheng <[email protected]>
|
Test result as below |
mikeferguson
requested changes
Feb 12, 2025
image_view/src/image_view_node.cpp
Outdated
| @@ -214,7 +214,7 @@ void ImageViewNode::imageCb(const sensor_msgs::msg::Image::ConstSharedPtr & msg) | |||
| } | |||
| } | |||
|
|
|||
| std::string encoding = msg->encoding.empty() ? "bgr8" : msg->encoding; | |||
| std::string encoding = "bgr8"; | |||
There was a problem hiding this comment.
this isn't the right fix - it would likely break mono8 usage.
If a particular encoding doesn't work for display, we should add a special rule for it below (see line 220-222 where we override bayer to mono8 - you can add another rule there for your yuv format that doesn't currently work)
Signed-off-by: Zhaoyuan Cheng <[email protected]>
|
Hi @mikeferguson This change ensures that if the input image encoding is YUV, it will be converted to BGR8 for display, while still handling other encodings appropriately. |
mikeferguson
approved these changes
Feb 13, 2025
ahcorde
approved these changes
Feb 13, 2025
|
https://github.com/Mergifyio backport jazzy humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 13, 2025
Signed-off-by: Zhaoyuan Cheng <[email protected]> (cherry picked from commit cebd97a)
mergify bot
pushed a commit
that referenced
this pull request
Feb 13, 2025
Signed-off-by: Zhaoyuan Cheng <[email protected]> (cherry picked from commit cebd97a) # Conflicts: # image_view/src/image_view_node.cpp
ahcorde
pushed a commit
that referenced
this pull request
Feb 13, 2025
…1075) Co-authored-by: Zhaoyuan Cheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on issue 1021, Fix the issue that the input image encoding as yuv, error to show