Fix ResizeNode to allow remapping both image and camera_info topics #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This resolves #703 . Linking the issue to maybe attract maintainers, because this is a crucial bug fix to make the node usable and it's been hanging here unmerged for 6 months... |
|
Based on who's been merging recent PRs, I think @JWhitleyWork is the right person to tag here for visibility. |
Signed-off-by: Joe Schornak <[email protected]>
clalancette
force-pushed
the
fix/resize-topic-remapping
branch
from
9d99668 to
2cd603c
Compare
|
Sorry for the incredibly long delay. LGTM. |
Thank you for following up! I just created #786 to backport this fix to Humble as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to how
image_transport::create_camera_subscriptioncreates acamera_infotopic from the provided image topic name, the current implementation ofimage_proc::ResizeNodeends up using the same topic name/camera_infofor both the input image subscriber and the output resized image publisher. This prevents remapping the input and output CameraInfo topics.This change makes
imageandresizetopic namespaces instead of image topic names, which allows the node to correctly separately use/image/camera_infoand/resize/camera_info.