Deprecate c headers #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CursedRock17 <[email protected]>
mikeferguson
requested changes
Oct 29, 2024
| @@ -32,7 +32,7 @@ | |||
| #ifndef TF2_SENSOR_MSGS_H | |||
| #define TF2_SENSOR_MSGS_H | |||
|
|
|||
| #include <tf2/convert.h> | |||
| #include <tf2/convert.hpp> | |||
There was a problem hiding this comment.
we should really wrap this with an if/else so that the branch continues to compile on older systems (since I expect this change to tf2 will only be released into rolling and later at this point):
#if __has_include(<tf2/convert.hpp>)
#include <tf2/convert.hpp>
#else
#include <tf2/convert.h>
#endif There was a problem hiding this comment.
This PR was meant to be preemptive one, that being said I'll probably do some backwards compatibility in which earlier branches like Humble will have the .h files include the .hpp files without a warning to prevent this from happening. In that case syntax like this shouldn't be needed.
| @@ -9,7 +9,7 @@ | |||
| #include "gtest/gtest.h" | |||
|
|
|||
|
|
|||
| #include <tf2/LinearMath/Quaternion.h> | |||
| #include <tf2/LinearMath/Quaternion.hpp> | |||
There was a problem hiding this comment.
same as above - let the branch work on multiple distros
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this pull request in
geometry2in which we deprecated the.hstyle headers in favor of.hpp.