-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More filters #3
base: hydro-devel
Are you sure you want to change the base?
More filters #3
Conversation
trim, bias, accel, gyro, tf all work really well. rviz is a work in progress but probably going to delete it working on a fusion of the accelerometer and gyro now (_simple)
Fused accel and gyro together, works well! :D :D
Added lisensing to all of my scripts.
I'm not sure if I should accept Mahony and Madgwick in this package as they are GPL licensed. Mixing the licensing on packages can be confusing. However, there isn't a lot that's as good as those implementations. |
This is also a fairly large pull request, can you split this out into at least:
I would also prefer the small python scripts to be implemented in C++ so there's the capability of running them on platforms that may not include python. |
This sounds like a good case for separate packages. |
Unfortunately, it sounds like separate packages would be best. The remaining question is where to host it... The package name "imu_pipeline" sounds like a great centralized location to put commonly used IMU filters. But it would seem that only BSD licensed c/c++ code is acceptable? (Understandable, but very frustrating!) Perhaps imu_pipeline should be reorganized into a meta package so each filter node can be located within it's own package hosted the imu_pipeline repository. This is advantageous for many reasons:
I think this solves all of the for-mentioned problems and yields a better overall experience for the ROS community, thoughts? If you like the idea, I have no problem volunteering to do the work. |
I have been working on a collection of imu filters that may be useful for the general public.
Here's a general outline of the idea I'm working towards: http://goo.gl/Mv2om0
So far the attitude filters work pretty well on the devices I've tested.
FYI: I'm working on the yaw estimation by integrating the magnetometer data, but it's still a work in progress. :)