Rotate image with transformation from image frame to target one#1031
Open
wkentaro wants to merge 1 commit intoros-visualization:indigo-develfrom
Open
Rotate image with transformation from image frame to target one#1031wkentaro wants to merge 1 commit intoros-visualization:indigo-develfrom
wkentaro wants to merge 1 commit intoros-visualization:indigo-develfrom
Conversation
wkentaro
force-pushed
the
feature/image-rotate
branch
from
d22ded0 to
205475e
Compare
wkentaro
force-pushed
the
feature/image-rotate
branch
from
205475e to
13099ca
Compare
Member
|
@wkentaro thanks for the pull request. I recently removed a dependency on OpenCV within rviz. It would be great to preserve this. Is there a way to do this which does not use OpenCV? It seems like a naive 2D rotation could be done using QImage and QTransform. |
Contributor
Author
|
I see. I've worked around a bit in https://github.com/wkentaro/rviz/commits/feature/image-rotate-without-opencv but got segv with current implement. |
Member
|
Unfortunately I'll have to insist that we keep OpenCV out of the dependencies for now. If you or anyone else has time to resurrect this using QImage that would be great. Until then I'll leave this here as untargeted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.