Do not warn about noetic EOF in upstream post-noetic-release #1851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This made sense for the last release in Noetic, but there is nothing wrong in ROS-O releases. Revert "Warning Dialog for ROS 1 EOL (ros-visualization#1843)" This reverts commit 8fe12bb.
rhaschke
approved these changes
Jul 9, 2025
Contributor
rhaschke
left a comment
rhaschke
left a comment
There was a problem hiding this comment.
Fair enough. Maybe we should branch off to ros-o to clarify that development is continuing for ROS-O? I think I never released a new rviz version with this warning...
Contributor
Author
|
a new branch here would make sense to me. How about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This made sense for the last release in Noetic, but there is nothing wrong in ROS-O releases and defining the environment variable everywhere is a cumbersome workaround.
Maybe it makes sense to push this in a new branch if we want to keep noetic-devel targeted only at ROS noetic?
Revert "Warning Dialog for ROS 1 EOL (#1843)"
This reverts commit 8fe12bb.