Enable to reset image display when new image has not been received for a while #1852
Conversation
rhaschke
left a comment
rhaschke
left a comment
There was a problem hiding this comment.
Interesting feature, but the implementation seems to be overly complicated.
You are running a periodic QTimer and update the timeout_time_ in its associated slot. Instead, you could simply update a last_received_ timestamp within incomingMessage() and directly call reset() in the slot function.
Are you fearing data races?
| { | ||
| if (reset_to_property_->getBool()) | ||
| { | ||
| reset_to_timer_->start(33); |
There was a problem hiding this comment.
Why this fixed timeout value? How is it motivated?
|
@rhaschke Thank you very much for your support, and I am deeply sorry for my super late response. |
|
I changed the default behavior deliberatively to report issues after 1s. |
|
I see. Thank you very much! |
2 participants
With this PR, you can switch on
Reset When Timed Outfunction, which makes image display show "No Image" again when new image has not been received forTimeoutseconds.This PR makes it easier to notice that the image publisher is in trouble.
Before this PR
Screencast.2025-07-11.19.46.35.compressed.mp4
After this PR
Screencast.2025-07-11.19.51.45.compressed.mp4
Note that the default state of
Reset When Timed Outis OFF, which leads to the same behavior before this PR.