Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feedback callback #39

Open
wants to merge 1 commit into
base: indigo-devel
Choose a base branch
from
Open

Add feedback callback #39

wants to merge 1 commit into from

Conversation

mkrogius
Copy link

@mkrogius mkrogius commented Jun 6, 2015

Adds a callback for the feedback from the action server. The callback is called with the userdata and the feedback message

@lgeo3
Copy link

lgeo3 commented Feb 1, 2016

Hi, is this pullrequest going to be accepted ? (I need the userdata in the feedback callback, and this commit seems to provide it)

@mkrogius
Copy link
Author

mkrogius commented Feb 4, 2016

Its been over a year and I haven't heard anything back, so I think its safe to assume its not going to happen.

@bajo
Copy link

bajo commented Feb 4, 2016

I fear the same, which is kind of sad, as this and some of the other open pull requests offer some nice additions so smach.
I for myself just cloned the executive_smach repo and merged the pull request into my local catkin workspace to be able to use them instead of the version that is released through the ros repository.

@lgeo3
Copy link

lgeo3 commented Feb 5, 2016

Ok, sad, @jbohren do you confirm ? Can we help you ?

@jbohren
Copy link
Member

jbohren commented Feb 5, 2016

@laurent-george et al. The real issue is a lack of time for thorough testing.

I've been meaning to get around to not only that things for a long time (as you can tell by messages on this project pages), but also migrate SMACH to use coroutines instead of threads.

AmandineMa pushed a commit to AmandineMa/executive_smach that referenced this pull request Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants