Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROS Noetic] Unrelease collada_urdf_jsk_patch and bayesian_belief_networks #26283

Closed

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Aug 24, 2020

Has always failed to build on all platforms.

jsk-ros-pkg/jsk_3rdparty#213
jsk-ros-pkg/jsk_3rdparty#215

Partially reverts #26088 @k-okada FYI

@sloretz sloretz changed the title [ROS Noetic] Unrelease collada_urdf_jsk_patch [ROS Noetic] Unrelease collada_urdf_jsk_patch and bayesian_belief_networks Aug 24, 2020
Copy link
Contributor Author

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; waiting for another reviewer to double check and merge 🙇

@mabelzhang
Copy link
Contributor

Looks good to me? But I have no idea the implications. The world can't be as innocent as it looks. I'm gonna let someone more useful approve this.

@k-okada
Copy link
Contributor

k-okada commented Aug 26, 2020

@sloretz @mabelzhang I think #26311 fixed issues.

@sloretz
Copy link
Contributor Author

sloretz commented Aug 26, 2020

Closing in favor of #26311

@sloretz sloretz closed this Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants