Allow name attribute in visual and collision tag [ros2 branch] #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow name attribute in visual tag * Add name kwarg at end Signed-off-by: Shane Loretz <[email protected]> * Add test for <visual name="..."> Signed-off-by: Shane Loretz <[email protected]> * Add version attribute to test Signed-off-by: Shane Loretz <[email protected]> Co-authored-by: Brian Gerkey <[email protected]> Co-authored-by: Shane Loretz <[email protected]>
traversaro
force-pushed
the
fixnamevisualcollision
branch
from
a293483 to
38d7f12
Compare
traversaro
changed the title
|
@mjcarroll From what I understand @clalancette will be mostly off for the next few months, I am not sure if there was any PMC discussion on the URDF repos as mentioned in ros/urdfdom#200 (comment) . |
It was less of discussion and more of a reminder that these repos also fall under the maintenance of the PMC and that folks should get to them when they can. I will make sure we can get a reviewer here, thanks for the ping. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is necessary to ensure that the parser is consistent with the URDF spec. The issue was solved in #31 and #67 for the
melodic-develbranch, but the changes were never cherry-picked or forward merged to theros2branch.