Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reuse logic from Time::durationToSec method #68

Open
dirk-thomas opened this issue Aug 21, 2018 · 2 comments · May be fixed by #672
Open

reuse logic from Time::durationToSec method #68

dirk-thomas opened this issue Aug 21, 2018 · 2 comments · May be fixed by #672
Labels
enhancement New feature or request

Comments

@dirk-thomas
Copy link
Member

As suggested in ros2/rclcpp#536 (comment) the logic could be moved to rcutils and be used in rclcpp::Time and rclcpp::Duration.
@dirk-thomas dirk-thomas added the enhancement New feature or request label Aug 21, 2018
@CursedRock17
Copy link
Contributor

CursedRock17 commented Mar 29, 2024 •
edited
Loading

I can open up a PR for this since it's a simple logic movement but I would assume it would make more sense to move the logic to rclcpp opposed to rcutils to keep rcutils concise. Does anybody else have any opinions on where it should be moved to?

@clalancette
Copy link
Contributor

I can open up a PR for this since it's a simple logic movement but I would assume it would make more sense to move the logic to rclcpp opposed to rcutils to keep rcutils concise.

I don't think we can do that. The problem is that tf2 does not, and cannot, depend on rclcpp. However, both tf2 and rclcpp currently depend on rcutils, so that is a logical place to share the implementation.

This was referenced Apr 16, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improved Accuracy with RCUTILS CursedRock17/geometry2
3 participants
@clalancette @dirk-thomas @CursedRock17