Improved Accuracy with RCUTILS #672
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CursedRock17 <[email protected]>
ahcorde
approved these changes
Apr 26, 2024
|
It looks like this PR is blocked on an issue in rmw_fastrtps ros2/rcutils#460 (comment) Assigning @ahcorde to look into it post-Jazzy 🧇 |
Signed-off-by: CursedRock17 <[email protected]>
|
As per this comment ros2/rcutils#460 (comment) it seems the general consensus was that we we're changing to a method opposed to a macro for increased accuracy, so I've just prepped this PR for when the other one is complete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is meant to pair with this
RCUTILSPR which will close #68, that way the feature is used immediately. I kept thedurationToSecfunction as to prevent an API/ABI breakage. The tests pass locally when theRCUTILSfix is applied, but they'll fail until the PR over there is resolved, as there will be too much error without the exact rounding seen originally in this repository.