Upstream minor fixes from Apex.AI #2240
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Orlov <[email protected]>
- Address clang16 warning in test Signed-off-by: Michael Orlov <[email protected]>
- Follow-up on #2150 Signed-off-by: Michael Orlov <[email protected]>
MichaelOrlov
changed the title
The rosbag_py Player does not reset its global static exit_ flag upon start playing. This leads to the situation when player instances created afterward can not start playing and stop immediately. Signed-off-by: Michael Orlov <[email protected]>
MichaelOrlov
changed the title
MichaelOrlov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upstream minor fixes we recently made in Apex.AI.
rosbag2_transport::Recorder classTestRecorderEventNotifier(will make tests less flaky).EventQoSfor event notifier publishers.The rosbag_py Player was not resetting its global static exit flag upon start playing. This led to a situation where player instances created afterward could not start playing and would stop immediately.
Fixes # (issue) N/A
Is this user-facing behavior change?
No.
Did you use Generative AI?
No.
Additional Information
No API/ABI breaking changes so far.