call propertyHiddenChanged synchronously #1033
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
clalancette
reviewed
Oct 16, 2023
| @@ -101,7 +101,7 @@ void PropertyTreeWidget::setModel(PropertyTreeModel * model) | |||
| if (model_) { | |||
| connect( | |||
| model_, SIGNAL(propertyHiddenChanged(const Property*)), | |||
| this, SLOT(propertyHiddenChanged(const Property*)), Qt::QueuedConnection); | |||
| this, SLOT(propertyHiddenChanged(const Property*))); | |||
There was a problem hiding this comment.
With the (rather large) caveat that I'm not super familiar with Qt's event loop, this seems like it has the same problem. That is, omitting this ends up using the "automatic" connection type from Qt: https://doc.qt.io/qt-5/qt.html#ConnectionType-enum . If the automatic connection type decides to use a queued connection, then you'll still have the same problem.
Should we instead make this a DirectConnection?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with this PR ros-visualization/rviz#1795
Property might no longer exist when event is triggered