PointStampedDisplay: Ignore incoming messages if disabled #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
|
Reading ros-visualization/rviz#1764 , it looks like the problem is with messages that have arrived, but not yet processed, when the plugin is disabled. Fixing that problem seems worthwhile. However, I'm not totally convinced that this is the way to do it. Reading ros-visualization/rviz#1764 (comment) , it looks like that particular fix did not fix the issue in Noetic (though it seems to have fixed it in Melodic, strangely). So while I think this is an OK fix to put in, I think we should also track down what the fix to Noetic was. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with this PR ros-visualization/rviz#1765 in RViz for ROS 1