Select QoS reliability policy in DepthCloud Plugin #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
| @@ -370,6 +404,7 @@ void DepthCloudDisplay::subscribe() | |||
| std::bind(&DepthCloudDisplay::processDepthMessage, this, std::placeholders::_1)); | |||
| } | |||
| } | |||
| subscription_start_time_ = rviz_ros_node_->get_raw_node()->now(); | |||
There was a problem hiding this comment.
Are we not using / exposing this variable anywhere else ? Could be removed otherwise.
There was a problem hiding this comment.
I created a new PR to fix the crash #1161
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
adityapande-1995
approved these changes
Mar 5, 2024
|
|
https://github.com/Mergifyio backport humble iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 6, 2024
Signed-off-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit a76cf91)
mergify bot
pushed a commit
that referenced
this pull request
Mar 6, 2024
Signed-off-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit a76cf91)
This was referenced Mar 6, 2024
ahcorde
added a commit
that referenced
this pull request
Mar 7, 2024
Signed-off-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit a76cf91) Co-authored-by: Alejandro Hernández Cordero <[email protected]>
ahcorde
added a commit
that referenced
this pull request
Mar 7, 2024
Signed-off-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit a76cf91) Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select QoS reliability policy in DepthCloud Plugin