Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve web accessibility for theme base16 comments #1952

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

designbymimmi
Copy link

Context

Increase color vs background color contrast in base16 theme to make it easier to read comments.

Screenshots using theme base16.dark

Before #505050 After #858585
comment-color-BEFORE-#505050 comment-color-AFTER-#858585

Web accessibility test results

Before After
contrast-result-BEFORE contrast-result-AFTER

Considerations

Tried to keep the comment color as "dark" as possible to keep it inline with the style of the theme while still improving the accessibility.

Increase color vs background color contrast to make it easier to read comments.
@epidemian
Copy link
Contributor

This is really nice. I personally find most dark themes unusable due to comments being so dark they are almost unreadable.

Luckily it's usually a simple config change to increase the contrast of comments. But dang, we shouldn't have these defaults :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants