-
Notifications
You must be signed in to change notification settings - Fork 771
Update Python builtin keywords, functions, and exceptions to Python version 3 #2109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0ae6928
to
3666812
Compare
@joclement Thank you for your contribution. Even though Python 2 is EOL, we still have users on the old version, plus we do not have a way to specify v2 and v3 like Pygments. For that reason, I would suggest avoid removing old keywords. What do you think? |
We don't interpret or run code, we only highlight it. Despite Python 2 being EOL, it is still reasonable to, e.g. write a blog post about it. I think there may be some merit into splitting these if they diverge too much, into e.g. a |
See rouge-ruby#2109 (comment). Revert "feat!: no longer detect Python2" This reverts commit 3666812.
Thank you for the feedback and sorry for not addressing this earlier. I reverted the changes dropping Python2 support. Using |
Signed-off-by: Joris Clement <[email protected]>
…ion 3 See: - https://docs.python.org/3/reference/lexical_analysis.html#keywords - https://docs.python.org/3/library/functions.html - https://docs.python.org/3/library/exceptions.html#exception-hierarchy Signed-off-by: Joris Clement <[email protected]>
Signed-off-by: Joris Clement <[email protected]>
See rouge-ruby#2109 (comment). Revert "feat!: no longer detect Python2" This reverts commit 3666812.
c94c2b5
to
b87e5cb
Compare
Thanks @joclement. LGTM 🚀 |
Python2 is EOL for a while now, see https://www.python.org/doc/sunset-python-2/. Thus, update the builtin keywords, function, and exceptions as how they are used by Python 3.
See:
- https://docs.python.org/3/reference/lexical_analysis.html#keywords
- https://docs.python.org/3/library/functions.html
- https://docs.python.org/3/library/exceptions.html#exception-hierarchy